-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release actions for dApp examples #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a research question and can be done in a different PR/issue:
Currently, if someone accidentally wrongly tags this repo e.g. euroe-demo/0.0.0
, this release pipeline is triggered. The release pipeline would look up the correct version and publish it to docker hub. Nonetheless, to not rely on the reviewer/approver of the release pipeline to check for a version mismatch, it would be nice if the release action could check (when it was triggered via a tag) that the versions match.
Yes, this is correct, but it's also one of those things where having this check adds extra complexity and problems. So I don't think this is really necessary for now. It's a nice to have that we can live without. |
We can create an issue for future research in the backlog. |
Co-authored-by: Doris Benda <[email protected]>
Co-authored-by: Doris Benda <[email protected]>
4e4d1fb
to
0d41a17
Compare
0d41a17
to
37312e6
Compare
37312e6
to
e7a292d
Compare
e7a292d
to
ce5c142
Compare
ce5c142
to
0639d23
Compare
Purpose
Closes #69.
Closes #78
Checklist
hard-to-understand areas.