Update dependency versions #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also update the github actions so that the linting will run? |
|
I don't have write access to this repo, so I can't update the actions |
|
There you go. There's a fair bit it's going to yell about, as there were some notable improvements. Unforunately, I don't think there's an auto fix for the fstrings, and they are legitimately better than str.format computationally |
…x, like line length in some log statements, and too many args
|
I'd reccomend adding line level pylint exceptions on those functions. For the log lines that are too long, you could do that same thing, or you could use python's method of splitting a line if there are logical places to |
Part of doing this was that I removed 'bad-continuation' from the disable list in the .pylintrc bc the linting action said that option has been removed from pylint. I left it commented out for now to make sure the lint passes, but I can delete it entirely before this pr is merged assuming this fix passes the check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to python 3.12, made the base image in the Dockerfile Debian 12, and updated dependency versions to be more up to date
oh i also made the dockerfile install libldap-common to fix the python-ldap issue