Send email when marked absent from house meeting #285
Conversation
Also sends an email when evals updates an active members house meeting attendance.
| import smtplib | ||
| from email.mime.text import MIMEText | ||
| from email.utils import formatdate | ||
| from email.mime.multipart import MIMEMultipart | ||
| from datetime import date | ||
| from conditional import app |
There was a problem hiding this comment.
Please organise these like in the rest of conditional:
- python modules
- pip modules
- local conditional modules
There was a problem hiding this comment.
this is already the case
There was a problem hiding this comment.
Separate with a line break please
| from conditional import app | ||
|
|
||
| def send_absent_hm_attendance_emails(absent_members): | ||
| today_date = date.today().strftime("%m/%d") |
There was a problem hiding this comment.
This is an ambiguous date format. Why not do 06 January instead? This doesn't need to be terse, so be readable.
There was a problem hiding this comment.
This was done to be consistent with the emails sent out by quotefault. And at least in the subject line conciseness is better imo.
There was a problem hiding this comment.
Quotefault does not include a date in emails. Please don't be terse in the body, at least.
Co-authored-by: Max Meinhold <[email protected]>
Co-authored-by: Max Meinhold <[email protected]>
|
Will squash into a single commit once approved. |
I did not know that, yikes |
Also sends an email when evals updates an active members house meeting
attendance.