Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Project History on Dashboard #150

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

liam-middlebrook
Copy link
Member

Change the Major Projects panel on the dashboard to show all of the
major projects ever submitted by a member.

@mbillow optionally we could also display the date here (but I personally don't think that's of vital importance).

Change the Major Projects panel on the dashboard to show all of the
major projects ever submitted by a member.
@@ -89,8 +89,7 @@ def display_dashboard():
'status': p.status,
'description': p.description
} for p in
MajorProject.query.filter(MajorProject.uid == member.uid,
MajorProject.date > start_of_year())]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashboard is meant to display information pertaining to the current evaluations period. With that said, I am not against showing history here, but it should be shown in the proper context. We should either change the styling of past year's major projects (grey them out, etc.) or put them in a new table called "Past Projects" or something of the like.

@mbillow
Copy link
Member

mbillow commented Aug 22, 2017

I just went through and adjusted all of the dates in the database to be "correct". (Based on when the project was passed/failed.)

We should add the date to this and maybe some "greyed-out" styling.

@audiolion
Copy link
Member

Any reason to not just do an archive view where you can go back through the years? e.g. see 2015-2016 academic year, 2016-2017 academic year through some archive url pattern and the default view shows current academic year? If someone goes to a year where they had no major projects you just have some default no major projects submitted this year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants