Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N°3777 - favicon: change easily favicon #619

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

accognet
Copy link
Contributor

Allow customization of favicon and logo depending on environment:

define them in XML first:

<brandings>
  <branding id="default">
      <main_favicon _delta="define">
        <fileref ref="main_favicon_default"/>
      </main_favicon>
      <login_favicon _delta="define">
        <fileref ref="login_favicon_default"/>
      </login_favicon>
      <portal_favicon _delta="define">
        <fileref ref="portal_favicon_default"/>
      </portal_favicon>
      <portal_favicon _delta="define">
        <fileref ref="portal_favicon_default"/>
      </portal_favicon>
      <main_logo _delta="define">
        <fileref ref="main_logo_default"/>
      </main_logo>
  </branding>
  <branding id="test_env">
      <main_favicon _delta="define">
        <fileref ref="main_favicon_test"/>
      </main_favicon>
      <login_favicon _delta="define">
        <fileref ref="login_favicon_test"/>
      </login_favicon>
      <portal_favicon _delta="define">
        <fileref ref="portal_favicon_test"/>
      </portal_favicon>
      <main_logo _delta="define">
        <fileref ref="main_logo_test"/>
      </main_logo>
  </branding>
<brandings>

and then you can choose different favicon and logo using the configuration file:

// branding_environment: type of branding. usefull for put different logo depending environment
'branding_environment' => 'test',
( portal favicon can also be customized in module_design:

  <module_designs>
    <module_design  id="itop-portal-customer"  _delta="must_exist">
      <properties>
        <favicon _delta="define">
          <fileref ref="logo_port_customer"/>
        </favicon>
      </properties>
    </module_design>
  </module_designs>

)

@accognet accognet self-assigned this Feb 26, 2024
@accognet accognet added the enhancement New feature or request label Feb 26, 2024
@Molkobain Molkobain added the internal Work made by Combodo label Feb 27, 2024
@Molkobain
Copy link
Contributor

What about themes? They are defined under the <branding> node, we can't duplicate them in each new <branding id="xxx"> node.

'app_icon_url' => [
'branding_environment' => [
'type' => 'string',
'description' => 'type of branding. usefull for put different logo depending environment',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo (useful)

@piRGoif
Copy link
Contributor

piRGoif commented Aug 21, 2024

Mind that favicon might not be a single file
Check https://www.emergeagency.com/insights/detail/the-essentials-of-favicons/

@Hipska
Copy link
Contributor

Hipska commented Aug 21, 2024

And more recent: https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal Work made by Combodo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants