Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N°6890 - Update request template data though the REST/JSON API #565

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

accognet
Copy link
Contributor

@accognet accognet commented Oct 31, 2023

@accognet accognet added the internal Work made by Combodo label Oct 31, 2023
@accognet accognet self-assigned this Oct 31, 2023
@rquetiez rquetiez self-requested a review June 10, 2024 13:14
@rquetiez
Copy link
Contributor

Reviewed today with Anne-Cath:

  1. Missing new test cases (see request-template)
  2. The implementation in MakeRealValue implies a change in the expected behavior (at least for the REST API) : it is not possible to reset the values. A PO decision has to be made, Then tests cases have to be added to cover these use cases.
  3. The implementation in CompareValues needs a rework : first, it will issue a warning when some fields are missing on the right value, and the meaning of the change is really unclear. CompareValues should be responsible for comparing PHP arrays, not for compensating the tricky behavior of the above layers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Work made by Combodo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants