Added employee profitability list #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage report for commit: e59722a Summary - Lines: 2.93% | Methods: 5.14%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Passing run #8306 ↗︎
Details:
Review all test suite changes for PR #3525 ↗︎ |
|||||||||||||||
shubtiwari
changed the title
P4NK4J
requested changes
Apr 9, 2024
Comment on lines
18
to
23
| Auth::user()->meta()->updateOrCreate( | ||
| ['meta_key' => 'profitability_threshold_value'], | ||
| ['meta_value' => $request->profitability_threshold_value] | ||
| ); | ||
|
|
||
| return redirect()->back()->with('status', 'Saved Successfully!'); |
There was a problem hiding this comment.
These values should go in settings table rather than user_meta, since it's a system variable
| @section('content') | ||
|
|
||
| @php | ||
| $route_name = Route::getCurrentRoute()->getName(); |
There was a problem hiding this comment.
We use camelCasing for variables here, let's replace it with $routeName all across
| @@ -30,6 +34,7 @@ | |||
| <thead class="thead-dark"> | |||
| <tr class="sticky-top"> | |||
| <th>Name</th> | |||
| @if($route_name==="employee") | |||
There was a problem hiding this comment.
Suggested change
| @if($route_name==="employee") | |
| @if($routeName === "employee") |
| <th> | ||
| Employee Earning | ||
| <span class="tooltip-wrapper" data-html="true" data-toggle="tooltip" title="In Hours"> | ||
| <i class="fa fa-info-circle" aria-hidden="true"></i> |
There was a problem hiding this comment.
Rather than tooltip we need to use alert symbol here
| <div class="col" id="user-settings-content"> | ||
| <div class="card-body"> | ||
| <h5 class="max-interview-heading fz-20"> Threshold value | ||
| <input type="number" class="col-xs text-center outline-none h-40 w-100 rounded-12 quantity" id="quantity" name="profitability_threshold_value" min="1" max="1000000" value="{{ old ('profitability_threshold_value', Auth::user()->metaValue('profitability_threshold_value')) }}"> |
There was a problem hiding this comment.
Let's not put a limit here, it can increase and decrease as per the organizations steam
routes/web.php
Outdated
Comment on lines
102
to
103
| Route::get('/profitability-threshold-value', 'profitabilityController@index')->name('settings.profitability-threshold-value'); | ||
| Route::post('/profitability-threshold-value', 'profitabilityController@update')->name('settings.update-profitability-threshold-value'); |
There was a problem hiding this comment.
It's minimum earning threshold to make an employee profitable, instead of a profitability threshold. Let's update the name, as profitability is not what is defined by this route variable. It can be employee-earning-threshold
…at/profitability-employee-list
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3525 +/- ##
===========================================
- Coverage 3.32% 3.31% -0.02%
- Complexity 588 590 +2
===========================================
Files 103 104 +1
Lines 2103 2112 +9
===========================================
Hits 70 70
- Misses 2033 2042 +9 ☔ View full report in Codecov by Sentry. |
Comment on lines
29
to
30
| Permission::updateOrCreate(['name' => 'employee_profitability_list.view']); | ||
|
|
There was a problem hiding this comment.
This should not be in this seeder file. Please check if there are any seeder for employee. Add it there.
shubtiwari
force-pushed
the
feat/profitability-employee-list
branch
from
c90f363 to
882f99e
Compare
GauravGusain98
approved these changes
Apr 16, 2024
P4NK4J
approved these changes
Apr 16, 2024
shubtiwari
added
the
status : ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #3534
Description of the changes
Query need to be hit to add the permission value
Breakdown & Estimates
Expected Time Range:
Actual Time:
Feedback Cycle
Cycle Count: 0
Checklist: