Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] Numpy - split() #6437

Merged
merged 9 commits into from
Apr 4, 2025
Merged

Conversation

karishma-battina
Copy link
Contributor

@karishma-battina karishma-battina commented Mar 31, 2025

Description

Introduce a new term entry on the .split() under built-in functions in NumPy.
Created file: docs/content/numpy/concepts/built-in-functions/terms/split/split.md

Issue Solved

Closes #6421

Type of Change

New Term for Existing Concept Entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@mamtawardhani mamtawardhani self-assigned this Mar 31, 2025
@mamtawardhani mamtawardhani added new entry New entry or entries numpy NumPy entries status: under review Issue or PR is currently being reviewed labels Mar 31, 2025
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @karishma-battina the entry looks good! 🚀

However, it is missing the ##Codebyte Example block. So, could you please add the ## Codebyte Example block at the end. Please note that the codebyte section is not followed by an output block, it just showcases the term in use.
Thank you!

@karishma-battina
Copy link
Contributor Author

@mamtawardhani, Thanks for the review. I have added the codebyte example block.

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry looks good for a second round of review! 🚀

Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry looks good to be merged, @karishma-battina! 🚀

@Sriparno08 Sriparno08 merged commit 32c8aa8 into Codecademy:main Apr 4, 2025
7 checks passed
Copy link

github-actions bot commented Apr 4, 2025

👋 @karishma-battina
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/numpy/built-in-functions/split

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Apr 4, 2025
@karishma-battina karishma-battina deleted the 6421-split branch April 4, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python - NumPy built-in functions: .split()
3 participants