ITP JAN 2025/ELFREDAH KEVIN-ALERECHI/DAT GROUP/Quote Generator App #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cjyuan
added
the
Review in progress
cjyuan
reviewed
Apr 13, 2025
There was a problem hiding this comment.
This requirement is not met.
When the page loads it should show a random quote from the
quotesarray on the screen. It should also show who said the quote.
It would be a better UX if the button does not shift its position when the quote length changes.
Please also fix this branch so that it contains only modified files that belong to this project.
There was a problem hiding this comment.
Can you move the JS code to a separate .js file?
Comment on lines
+91
to
+114
| const quotes = [ | ||
| { | ||
| quote: "Life isn't about getting and having, it's about giving and being.", | ||
| author: "Kevin Kruse", | ||
| }, | ||
| { | ||
| quote: "Whatever the mind of man can conceive and believe, it can achieve.", | ||
| author: "Napoleon Hill", | ||
| }, | ||
| { | ||
| quote: "Strive not to be a success, but rather to be of value.", | ||
| author: "Albert Einstein", | ||
| }, | ||
| { | ||
| quote: | ||
| "Two roads diverged in a wood, and I—I took the one less traveled by, And that has made all the difference.", | ||
| author: "Robert Frost", | ||
| }, | ||
| { | ||
| quote: "I attribute my success to this: I never gave or took any excuse.", | ||
| author: "Florence Nightingale", | ||
| }, | ||
| // Add more quotes here if needed | ||
| ]; |
There was a problem hiding this comment.
I think you should use the quotes included in quotes.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.