Skip to content

ITP_JAN_25 | HASAN DEMIROZ | Module-Data-Groups | SPRINT 3 - AlarmClock #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ITP_JAN_25 | HASAN DEMIROZ | Module-Data-Groups | SPRINT 3 - AlarmClock #490

wants to merge 4 commits into from

Conversation

hasandemiroz
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@hasandemiroz
alarmclock file update

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
d901dd9
@hasandemiroz hasandemiroz added the Needs Review Participant to add when requesting review label Apr 8, 2025
@cjyuan cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Apr 13, 2025
cjyuan
cjyuan reviewed Apr 13, 2025
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works fine if a user only clicks the "Set Alarm" button once.
However, if the user enters a time and then clicks the "Set Alarm" button multiple times, the countdown clock will not display properly.

Some unusual input value can make the app function abnormally.

You missed updating index.html according to an instruction in readme.md.

Can you fix these issues?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 13, 2025
@hasandemiroz
Copy link
Author

Thank you for your review @cjyuan. The code fixed and pushed the changes. Pls, can you review again? @cjyuan

@hasandemiroz hasandemiroz added the Needs Review Participant to add when requesting review label Apr 16, 2025
@cjyuan
Copy link

cjyuan commented Apr 16, 2025

Should negative numbers be allowed?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Reviewed Volunteer to add when completing a review Needs Review Participant to add when requesting review labels Apr 16, 2025
@hasandemiroz
Copy link
Author

Thank you @cjyuan. I have tested and updated the code. It accepts only positive numbers now. Pls, can you review again?

@cjyuan cjyuan added Complete Participant to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hasandemiroz @cjyuan