ITP_JAN_25 | HASAN DEMIROZ | Module-Data-Groups | SPRINT 2 #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hasandemiroz, please add 'needs review' label to get a quicker review! |
day-lee
added
Needs Review
day-lee
reviewed
Apr 8, 2025
Comment on lines
+15
to
+19
| if (queryParams[key]) { | ||
| queryParams[key] = [].concat(queryParams[key], value); | ||
| } else { | ||
| queryParams[key] = value; | ||
| } |
There was a problem hiding this comment.
What does this line do? Does concat() necessary when join() has already joined all values back into one string?
day-lee
reviewed
Apr 8, 2025
Sprint-2/interpret/invert.js
Outdated
|
|
||
| // c) What does Object.entries return? Why is it needed in this program? | ||
| // The current return value is wrong because the key and value are not swapped properly. The value is being overwritten by the key instead. |
There was a problem hiding this comment.
This is duplicate answer. Please write an anwer to the question c.
day-lee
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.