Skip to content

London_ITP_Jan_2025 | Franklin Kamela | Module_Data_Groups | Feature_Quote_Generator #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

London_ITP_Jan_2025 | Franklin Kamela | Module_Data_Groups | Feature_Quote_Generator #480

wants to merge 3 commits into from

Conversation

Fradoka
Copy link

@Fradoka Fradoka commented Apr 2, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Splitting up sprint 3 into multiple PRs for each exercise.

Questions

Ask any questions you have for your reviewer.

@Fradoka Fradoka added Reviewed Volunteer to add when completing a review Complete Participant to add when work is complete and review comments have been addressed labels Apr 2, 2025
@halilibrahimcelik halilibrahimcelik self-requested a review April 10, 2025 09:41
halilibrahimcelik
halilibrahimcelik approved these changes Apr 10, 2025
View reviewed changes
Copy link

@halilibrahimcelik halilibrahimcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good you can close this pr now well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halilibrahimcelik halilibrahimcelik halilibrahimcelik approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fradoka @halilibrahimcelik