ITP-JAN-LONDON|FOROGH AGHAEIYARIJANI|MODULE-DATA-GROUP|SPRINT3|SLIDESHOW APP|Image carousel #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forogh-Aghaeiyarijani
added
the
Needs Review
5 tasks
cjyuan
reviewed
Apr 8, 2025
There was a problem hiding this comment.
-
Code is working great.
-
Not all the requirements specified in "Level 1 Challenge" in
readm.mdare met. (Can you find out what you missed and update your code accordingly?) -
Consider setting fixed dimensions for the displayed image to prevent the buttons from shifting positions due to changes in image size.
-
After you have made the necessary changes, you can mark this as "Complete".
Comment on lines
+20
to
+30
| autoBackwardBtn.textContent = "Auto Backward"; | ||
| stopBtn.textContent = "Stop"; | ||
|
|
||
| autoForwardBtn.id = "auto-forward"; | ||
| autoBackwardBtn.id = "auto-backward"; | ||
| stopBtn.id = "stop"; | ||
|
|
||
| document.body.appendChild(autoForwardBtn); | ||
| document.body.appendChild(autoBackwardBtn); | ||
| document.body.appendChild(stopBtn); |
There was a problem hiding this comment.
Why not just add these as HTML elements in index.html?
cjyuan
added
Reviewed
Forogh-Aghaeiyarijani
added
the
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.