ITP JAN 2025 | ELFREDAH KEVIN-ALERECHI | DATA FLOW | BOOK LIBRARY #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or yes or no if I read the book
|
Please, I still can't add label to my PR. The aspect to add label isn't highlighted. @cjyuan |
|
Have you clicked the link in the Github's invitation email to join CYF Github Org? |
|
yes, I have. Please, Can you resend it so that i can check if i missed
anything?
ᐧ
…On Tue, 8 Apr 2025 at 13:47, CJ Yuan ***@***.***> wrote:
Have you clicked the link in the Github's invitation email to join CYF
Github Org?
—
Reply to this email directly, view it on GitHub
<#188 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT72B2Q6FYQ2B3PAEGOEXD32YPAMJAVCNFSM6AAAAAB2WELPSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBWGMZDINJUGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*cjyuan* left a comment (CodeYourFuture/Module-Data-Flows#188)
<#188 (comment)>
Have you clicked the link in the Github's invitation email to join CYF
Github Org?
—
Reply to this email directly, view it on GitHub
<#188 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT72B2Q6FYQ2B3PAEGOEXD32YPAMJAVCNFSM6AAAAAB2WELPSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBWGMZDINJUGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I do not have the permission to do so. You have to talk to Barath on Slack. |
|
@halilibrahimcelik Please, can my pull request |
halilibrahimcelik
added
the
Review in progress
|
User shouldn't be able to add books if one the field is missing, please fix this problem |
halilibrahimcelik
requested changes
Apr 12, 2025
| pages.value == "" | ||
| title.value === "" || | ||
| author.value === "" || | ||
| pages.value === "" |
There was a problem hiding this comment.
please check your submit validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.