Skip to content

ITP_JAN25| Sheetal_Kharab| Module-Data-Flows| Programmer-Humour #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sheetalkharab
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Fetch comic data from api

Questions

Ask any questions you have for your reviewer.

@sheetalkharab sheetalkharab added the Needs Review Participant to add when requesting review label Apr 5, 2025
@sheetalkharab sheetalkharab linked an issue Apr 5, 2025 that may be closed by this pull request
Copy link

@shieldo shieldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The latest comic is fetched and loaded successfully into the DOM.

max-width: 90%;
height: auto;
margin-top: 20px;
border: 2px, solid black;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but there is a syntax issue in this line of CSS that is causing the property value to be invalid. Can you spot what it is?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello shieldo, Thanks for review. i found the mistake and committed the change. please review it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shieldo please suggest can i change label to complete?

@shieldo shieldo added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TECH ED] Programmer Humour
2 participants