-
-
Notifications
You must be signed in to change notification settings - Fork 69
ITP_JAN25| Sheetal_Kharab| Module-Data-Flows| Programmer-Humour #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! The latest comic is fetched and loaded successfully into the DOM.
fetch/programmer-humour/style.css
Outdated
max-width: 90%; | ||
height: auto; | ||
margin-top: 20px; | ||
border: 2px, solid black; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but there is a syntax issue in this line of CSS that is causing the property value to be invalid. Can you spot what it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello shieldo, Thanks for review. i found the mistake and committed the change. please review it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shieldo please suggest can i change label to complete?
Learners, PR Template
Self checklist
Changelist
Fetch comic data from api
Questions
Ask any questions you have for your reviewer.