Skip to content

London-ITP-Jan2025| Sabita Shrestha| Module-Data-Flows| Book-library| week2 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

London-ITP-Jan2025| Sabita Shrestha| Module-Data-Flows| Book-library| week2 #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
473d3fc
debugged script.js
SabitaShrestha325 Apr 5, 2025
7155231
change the other way to delete table, remove id and and rename button
SabitaShrestha325 Apr 9, 2025
e2e86d3
fixed html
SabitaShrestha325 Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,16 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Sabita Book Library</title>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
<link rel="stylesheet" type="text/css" href="style.css">
</head>

<body>
Expand All @@ -36,37 +32,37 @@ <h1>Library</h1>
id="title"
name="title"
required
/>
>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
>
</div>
</div>

Expand Down
91 changes: 47 additions & 44 deletions debugging/book-library/script.js
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of input validation,

  1. Are all input properly checked?
  2. Can .value be null? (Do we need to check someInputElement.value == null?)
  3. What if a user enters only space characters in the "title" input field?
  4. What if a users enters -1 or 3.1416 in the "pages" input field?

With the way the book's title is assigned to an HTML element (line 69), a book with a title containing special character sequence such as <i> can possibly ruin the display.

Lines 75, 89:

  • Is the value assigned to these id attribute unique?
  • Is there a need to assign an id attribute to delButton?
  • Is there a need to assign an id attribute to changeBut (at line 72)?

Lines 74, 88:

  • Can you think of a more consistent way to name the variables representing the two buttons, changeBut and delButton?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your review. I have made the changes as mentioned; could you please review my work and let me know if anything needs to be adjusted? Thank you.

Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,25 @@ const check = document.getElementById("check");
//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
const titleValue =title.value.trim();
const authorValue = author.value.trim();
const pagesValue = pages.value.trim();
if (!titleValue || !authorValue || !pagesValue) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
}

const pagesInt = parseInt(pagesValue, 10);
if (isNaN(pagesInt) || pagesInt <= 0) {
alert("Please enter a valid number of pages!");
return false;


}
let book = new Book(title.value, author.value, pagesInt, check.checked);
myLibrary.push(book);
render();
}
}

function Book(title, author, pages, check) {
this.title = title;
Expand All @@ -52,52 +57,50 @@ function Book(title, author, pages, check) {

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
let tbody = table.querySelector("tbody");


//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
tbody.innerHTML = "";
""
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
myLibrary.forEach((book, index) => {
let row = tbody.insertRow();
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

titleCell.textContent = book.title;
authorCell.textContent = book.author;
pagesCell.textContent = book.pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
let changeReadStatusButton = createButton("btn btn-success", book.check ? "yes" : "No");
wasReadCell.appendChild(changeReadStatusButton);
changeReadStatusButton.addEventListener("click", function () {
book.check = !book.check;
render();
});


//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
let deleteButton = createButton("btn btn-warning", "Delete");
deleteCell.appendChild(deleteButton);
deleteButton.addEventListener("click", function () {
alert(`You've deleted title: ${book.title}`);
myLibrary.splice(index, 1); // Remove the book from the array
render();
});
}
});
}
function createButton(className, text) {
let button = document.createElement("button");
button.className = className;
button.textContent = text;
return button;
}