LON | Amir Montazeri | Module-Data-Flows | Book-Library

[Amirmontazerii]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

• Renamed ambiguous variables (e.g., changeBut to toggleReadButton, delButton to deleteBookButton) for improved clarity.
• Updated DOM element references to have more descriptive names (e.g., title to titleInput).
• Replaced manual for loop in render() with forEach for readability.
• Renamed functions for clarity and to follow best practices (e.g., submit to submitBookForm).
• Improved code readability and maintainability through consistent naming conventions.

Questions

Ask any questions you have for your reviewer.

[jenny-alexander]

Good job fixing the bugs - the application is working well now.
You also did a good job replacing the 'let' variables with 'const'. 👏

Please make the following changes to make your code even better.

• The browser tab currently shows '127.0.0.1:555/debugging/book-library. Can you update it to be more explanatory to the user. If you want to read more about this here is a doc: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/title

• The changelist portion of your pull request is currently empty. This is an important part that helps other engineers understand what you've modified.
  Could you please add a brief description of your changes in the changelist section? Even a simple summary is will be beneficial.

[jenny-alexander]

It's possible that using changeBut to denote a button might be confusing to someone reviewing your code. Can you replace with a clearer name here and at line 86? Here are some tips:

• it's recommended to start with a verb for functions
• it's okay to use btn to shorten button. Personally, I use 'button' to be clear

[Amirmontazerii]

@jenny-alexander thank you for review, I changed the name of variable to a more descriptive name.