-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows environment fixes #2
Open
EswarBalasubramanian
wants to merge
3
commits into
CodeWithMa:dev
Choose a base branch
from
EswarBalasubramanian:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
numpy==1.24.1 | ||
numpy==1.26.0 | ||
opencv-python==4.7.0.68 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,15 @@ | ||
import os | ||
import platform | ||
|
||
|
||
def capture_screenshot(filename): | ||
""" | ||
Captures a screenshot of the Android screen using adb and saves it to a file. | ||
Returns True if the adb command was successful, False otherwise. | ||
""" | ||
adb_command = "adb exec-out screencap -p > {} 2> /dev/null".format(filename) | ||
if platform.system() == "Windows": | ||
adb_command = "adb exec-out screencap -p > {}".format(filename) | ||
else: | ||
adb_command = "adb exec-out screencap -p > {} 2> /dev/null".format(filename) | ||
EswarBalasubramanian marked this conversation as resolved.
Show resolved
Hide resolved
|
||
error_code = os.system(adb_command) | ||
return error_code == 0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you use
val > 0.42
? I tested the changes from your PR and I had to change this to0.43
. With0.42
it detected every screen as max number of games played and just stopped.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I used it in my small android device, even after capturing the text in the screenshot, the bot unable to detect it and loops clicking the battle button. The 0.42 is the value where max games played screenshot score exceeds, battle button screenshot score
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I have refactored quite a bit in the meantime. I had the same problem and added a priority list if multiple images match. See #4 and
PVPokeLossBot/src/image_decision_maker.py
Line 47 in 683f475
I have cherry picked your other changes for windows support in #3 and merged them.