Archive Cloudwatch Log Groups by Tag and update Python to 3.9 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichik
requested changes
Oct 11, 2022
| @@ -199,6 +202,10 @@ Parameters: | |||
| Description: Prefix to match against log group that should be exported (leave | |||
| empty to export all log groups) | |||
| Type: String | |||
| LogGroupTagName: | |||
| Default: 'archive_log_group_to_s3' | |||
There was a problem hiding this comment.
I think the default should be empty to keep backwards compatibility.
| tags_in_group_response = logs_client.list_tags_log_group( | ||
| logGroupName = log_group_name | ||
| ) | ||
| print("tags_in_group_response", tags_in_group_response) |
| print("tags_in_group_response", tags_in_group_response) | ||
| for tag in tags_in_group_response["tags"]: | ||
| if tag == "${LogGroupTagName}": | ||
| subscribe(log_group_name) |
There was a problem hiding this comment.
Can we add a break here just in case? Don't want for it to be possible to get double subscribe (which I think results in an exception).
| @@ -737,7 +753,7 @@ Resources: | |||
| Fn::GetAtt: | |||
| - LogSubscriberRole | |||
| - Arn | |||
| Runtime: python3.6 | |||
| Runtime: python3.9 | |||
| Timeout: 300 | |||
There was a problem hiding this comment.
Let's increase the timeout since we're doing much more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LogGroupTagName parameter that allows users to define a tag that can be added to a Log Group to mark it for Archiving to S3 bucket. By default, tag is "archive_log_group_to_s3".