Set the pool to 20 in test_helper.rb. #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsh2102
approved these changes
Mar 20, 2025
|
Interesting. I didn't edit the last line myself. Rather, I used GitHub's build-in web editor to add line 21. I appears that the original file did not terminate in a LF (Line Feed). The Linux standard expects all text files to end in an LF. A lot of Linux editors automatically add one if it is missing, and it appears that GitHub's web editor is programmed to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am the maintainer of the Debian with_advisory_lock package.
https://tracker.debian.org/pkg/ruby-with-advisory-lock
Currently, tests are failing during build because the environment spawns a pool of 5 but the tests run with 10 workers, leading some of the connections to fail.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095888
The solution is this simple pull request.
https://lists.debian.org/debian-ruby/2025/03/msg00013.html
I have already applied this to the Debian package, but I assume that having it upstream will be helpful for other people.