Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: created dynamic config based on env variables #194

Merged
merged 10 commits into from
Mar 4, 2024

Conversation

kkyusuftk
Copy link
Collaborator

@kkyusuftk kkyusuftk commented Feb 29, 2024

Problem:
We are maintaining two separate config for generating output files. In future we might want to have more of the code which we want to bundle slightly differently. In that scenario, creating new configs is not a scalable solution.

Solution:
Making our rollup config more dynamic.
We get rid of sw_rollup.config.js in favour of just one config. We segregate the build by passing MODE env variable.

Test:
I have deleted the generated files in the repository and re-generated it with the new config. No extra changes were commited and no extra files were changed.

@kkyusuftk
Copy link
Collaborator Author

This is a pre requisite to my shopify changes which will come after this PR.

@KambleSonam KambleSonam changed the base branch from master to develop March 1, 2024 11:05
@kkyusuftk kkyusuftk merged commit cf915cd into develop Mar 4, 2024
2 checks passed
@kkyusuftk kkyusuftk deleted the feat/merge-configs branch March 4, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants