-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs on clever logs and enable retry #658
Conversation
b1cc170
to
887284d
Compare
🔎 A preview has been automatically published:
This preview will be deleted once this PR is closed. |
I'm not sure of what is expected or not, but here is what I observe (remember, I'm under macOS): If I cut Wi-Fi:
If I cut Wi-Fi for a short time and it gets back:
If I use
If I use only
If I use
Verbose
|
I run some local tests and everything seem to work as expected. Good job! |
When the clever-tools were using the `request.superagent` from the clever-client, `EAI_AGAIN` and `ECONNRESET` errors were caught, and message were improved. When we moved to the common request.fetch, we lost improvment. This commit adds back the improved messages but in the clever-tools code.
This option was available on the superagent implementation but not on the fecth implementation.
The inner implementation of Logger.debug already does nothing if the CLEVER_VERBOSE is not enabled
c6b13c4
to
18083ca
Compare
With the latest build/push, evrything is ok for me: the CLI waits for an internet connection if it's missing at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA OK
18083ca
to
a4ec4b9
Compare
🔎 The preview has been automatically deleted. |
What is in this PR?
EAI_AGAIN
andECONNRESET
I also took the opportunity to fix/refactor a few details in the code (see commits).
What to QA?
Download the preview binary and test
clever logs
:--since
--until
--since
and--until
-v
You can also test
clever restart
orclever deploy
with network failures.This app is really helpful to test logs https://github.com/CleverCloud/clever-test-logs