Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor_change] Add nd_rest as a new generic ND REST API module. (DCNE-242) #109

Merged
merged 9 commits into from
Mar 20, 2025

Conversation

gmicol
Copy link
Collaborator

@gmicol gmicol commented Dec 12, 2024

Fixes #107

Addition of a new module nd_rest to handle generic ND REST API requests.

@gmicol gmicol added enhancement New feature or request jira-sync Sync this issue to Jira labels Dec 12, 2024
@gmicol gmicol self-assigned this Dec 12, 2024
@github-actions github-actions bot changed the title [minor_change] Add nd_rest as a new generic ND REST API module. (DNCE-242) [minor_change] Add nd_rest as a new generic ND REST API module. (DNCE-242) (DCNE-242) Dec 12, 2024
@gmicol gmicol changed the title [minor_change] Add nd_rest as a new generic ND REST API module. (DNCE-242) (DCNE-242) [minor_change] Add nd_rest as a new generic ND REST API module. (DCNE-242) Dec 12, 2024
@gmicol gmicol force-pushed the nd_rest branch 2 times, most recently from b5a4cdf to 1af8cb5 Compare December 16, 2024 17:35
@gmicol gmicol force-pushed the nd_rest branch 2 times, most recently from 97d17c4 to 4ecdcb9 Compare December 17, 2024 09:23
@gmicol gmicol requested review from samiib and akinross January 10, 2025 18:46
@gmicol gmicol requested a review from akinross January 22, 2025 18:55
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmicol gmicol requested a review from akinross January 27, 2025 16:21
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…king as intended and add test task and example in Documentation for URL query string using orderBy.
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmicol gmicol requested a review from anvitha-jain March 4, 2025 18:26
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit a2d9f24 into CiscoDevNet:master Mar 20, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira-sync Sync this issue to Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic ND REST API Module (DCNE-242)
7 participants