Reduce the max code complexity

ChrisMBarr · Jun 2, 2024 · cc7ef7d · cc7ef7d
1 parent dcd5ff6
commit cc7ef7d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -37,7 +37,7 @@ export default tseslint.config(
       '@typescript-eslint/strict-boolean-expressions': 'warn',
 
       'array-callback-return': 'warn',
-      complexity: ['warn', { max: 15 }],
+      complexity: ['warn', { max: 7 }],
       eqeqeq: ['warn', 'always', { null: 'ignore' }],
       'no-unused-vars': 'warn',
       'object-shorthand': ['warn', 'always'],

diff --git a/src/parser.ts b/src/parser.ts
@@ -27,6 +27,7 @@ export class Parser {
     };
   }
 
+  // eslint-disable-next-line complexity -- This does a lot of null coalescing, which is seen as a code branch that increases complexity. What this actually does is not that complex, so we ar OK to disable this rule here to allow our overall lint complexity to be enforced lower
   public getSongProperties(props: xmlModel.IXmlProperties): parserModel.IParserProperties {
     // console.log('props', props);
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,6 +27,7 @@ export class Parser { @@
         };
       }
+      // eslint-disable-next-line complexity -- This does a lot of null coalescing, which is seen as a code branch that increases complexity. What this actually does is not that complex, so we ar OK to disable this rule here to allow our overall lint complexity to be enforced lower
       public getSongProperties(props: xmlModel.IXmlProperties): parserModel.IParserProperties {
         // console.log('props', props);
@@ Expand Down @@