Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-689] Port test_nft_offers.py to WalletTestFramework #19265

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Quexington
Copy link
Contributor

Another PR migrating our wallet tests to the paradigmatic WalletTestFramework. As has been the case for recent PRs, no wallet changes were needed, this is purely a test change.

@Quexington Quexington added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Tests Changes to tests labels Feb 13, 2025
Copy link

Pull Request Test Coverage Report for Build 13314238807

Details

  • 176 of 176 (100.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.01%) to 91.516%

Files with Coverage Reduction New Missed Lines %
chia/full_node/pending_tx_cache.py 1 96.55%
chia/daemon/server.py 1 83.46%
chia/rpc/rpc_server.py 4 88.24%
chia/wallet/wallet_node.py 4 87.96%
chia/_tests/core/util/test_lockfile.py 4 88.43%
Totals Coverage Status
Change from base Build 13291657602: 0.01%
Covered Lines: 105071
Relevant Lines: 114634

💛 - Coveralls

@Quexington Quexington marked this pull request as ready for review February 13, 2025 23:42
@Quexington Quexington requested a review from a team as a code owner February 13, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Tests Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant