Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-2320 Annotate test_full_node.py #19226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

This allows the file (and its users) to benefit from type checking.

Current Behavior:

This file is excluded from mypy type checking.

New Behavior:

This file is now type annotated and included in mypy type checking.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Feb 4, 2025
@AmineKhaldi AmineKhaldi self-assigned this Feb 4, 2025
Copy link

Pull Request Test Coverage Report for Build 13134318072

Details

  • 152 of 152 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.543%

Files with Coverage Reduction New Missed Lines %
chia/_tests/core/util/test_lockfile.py 1 90.74%
chia/full_node/full_node.py 8 85.99%
Totals Coverage Status
Change from base Build 13117920682: 0.02%
Covered Lines: 105330
Relevant Lines: 114883

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Feb 5, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Feb 5, 2025
@AmineKhaldi AmineKhaldi force-pushed the annotate_test_full_node branch from 4648b3e to 5072511 Compare February 11, 2025 10:50
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Feb 11, 2025
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@AmineKhaldi AmineKhaldi reopened this Feb 12, 2025
@AmineKhaldi AmineKhaldi marked this pull request as ready for review February 12, 2025 15:59
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner February 12, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant