-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add serial id #92
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👏🏻 We can address #116 in a follow-up PR.
This comment was marked as outdated.
This comment was marked as outdated.
@juliangruber it seems that I still need your approval because there are changes requested, but I do not see any for this PR. Could I ask you to PTAL? |
We could dismiss Julians review, WDYT? cc @bajtos |
Ping @bajtos |
We believe Julian's feedback has been addressed by now.
The table
active_deals
does not have a unique property right now. This makes it tedious to fetch deals as one needs to check each field to a specific value to retrieve it. We can make this shorter by introducing a serial and set it as the primary key of the tableactive_deals
. Consequently, we only need to ask for the primary key if we want to fetch or update a certain deal.This PR adds a serial to the active deals table which is then set as the primary key with the column name
id
.Closes #86