Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add serial id #92

Merged
merged 11 commits into from
Mar 6, 2025
Merged

chore: add serial id #92

merged 11 commits into from
Mar 6, 2025

Conversation

NikolasHaimerl
Copy link
Contributor

@NikolasHaimerl NikolasHaimerl commented Feb 10, 2025 •
edited
Loading

The table active_deals does not have a unique property right now. This makes it tedious to fetch deals as one needs to check each field to a specific value to retrieve it. We can make this shorter by introducing a serial and set it as the primary key of the table active_deals. Consequently, we only need to ask for the primary key if we want to fetch or update a certain deal.

This PR adds a serial to the active deals table which is then set as the primary key with the column name id.
Closes #86

@NikolasHaimerl NikolasHaimerl marked this pull request as ready for review February 10, 2025 10:27
pyropy

This comment was marked as resolved.

Sign in to view

@NikolasHaimerl

This comment was marked as resolved.

Sign in to view
@pyropy

This comment was marked as resolved.

Sign in to view
juliangruber
juliangruber previously requested changes Feb 10, 2025
View reviewed changes
@juliangruber

This comment was marked as resolved.

Sign in to view
@NikolasHaimerl NikolasHaimerl mentioned this pull request Feb 11, 2025
Merged
@NikolasHaimerl

This comment was marked as resolved.

Sign in to view
@NikolasHaimerl

This comment was marked as resolved.

Sign in to view
bajtos

This comment was marked as resolved.

Sign in to view

@pyropy

This comment was marked as resolved.

Sign in to view
bajtos

This comment was marked as resolved.

Sign in to view

@NikolasHaimerl

This comment was marked as resolved.

Sign in to view
Nikolas Haimerl added 2 commits February 17, 2025 12:05
@NikolasHaimerl NikolasHaimerl enabled auto-merge (squash) February 18, 2025 08:42
@pyropy

This comment was marked as resolved.

Sign in to view
@NikolasHaimerl

This comment was marked as outdated.

Sign in to view
@pyropy

This comment was marked as resolved.

Sign in to view
@NikolasHaimerl

This comment was marked as outdated.

Sign in to view
@NikolasHaimerl NikolasHaimerl mentioned this pull request Feb 19, 2025
Open
pyropy
pyropy approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👏🏻 We can address #116 in a follow-up PR.

@bajtos

This comment was marked as outdated.

Sign in to view
@NikolasHaimerl
Copy link
Contributor Author

@juliangruber it seems that I still need your approval because there are changes requested, but I do not see any for this PR. Could I ask you to PTAL?

@pyropy
Copy link
Contributor

pyropy commented Mar 4, 2025

@juliangruber it seems that I still need your approval because there are changes requested, but I do not see any for this PR. Could I ask you to PTAL?

We could dismiss Julians review, WDYT? cc @bajtos

@NikolasHaimerl NikolasHaimerl disabled auto-merge March 6, 2025 11:23
@NikolasHaimerl NikolasHaimerl enabled auto-merge (squash) March 6, 2025 11:23
@NikolasHaimerl
Copy link
Contributor Author

@juliangruber it seems that I still need your approval because there are changes requested, but I do not see any for this PR. Could I ask you to PTAL?

We could dismiss Julians review, WDYT? cc @bajtos

Ping @bajtos

@bajtos bajtos dismissed juliangruber’s stale review March 6, 2025 12:30

We believe Julian's feedback has been addressed by now.

@NikolasHaimerl NikolasHaimerl merged commit d0302f7 into main Mar 6, 2025
8 checks passed
@NikolasHaimerl NikolasHaimerl deleted the nhaimerl-auto-index branch March 6, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@pyropy pyropy pyropy approved these changes

@juliangruber juliangruber Awaiting requested review from juliangruber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column Uniqueness for active deals
4 participants
@NikolasHaimerl @pyropy @juliangruber @bajtos