semantic improvements

Chaphasilor · Oct 3, 2020 · b020a57 · b020a57
1 parent bbb4976
commit b020a57
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -13,6 +13,5 @@ module.exports = {
   rules: {
     'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
     'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
-    'vue/no-use-v-if-with-v-for': 'warn',
   }
 }
diff --git a/src/components/LinkRow.vue b/src/components/LinkRow.vue
@@ -35,7 +35,7 @@
     >
 
       <button
-        class="h-full mx-1 px-2 rounded-full font-bold hover:bg-gray-400 dark:hover:bg-gray-700 focus:outline-none transition-colors duration-75"
+        class="h-full mx-1 px-2 rounded-full font-bold sm:hover:bg-gray-400 dark:sm:hover:bg-gray-700 focus:outline-none transition-colors duration-75"
         @click="copyLinkToClipboard"
       >
         <transition
@@ -97,7 +97,7 @@
     >
 
       <button
-        class="h-full mx-1 px-2 rounded-full font-bold hover:bg-gray-400 dark:hover:bg-gray-700 focus:outline-none transition-colors duration-75"
+        class="h-full mx-1 px-2 rounded-full font-bold sm:hover:bg-gray-400 dark:sm:hover:bg-gray-700 focus:outline-none transition-colors duration-75"
         @click="shareLink"
       >
         <svg
@@ -126,7 +126,7 @@
       class="w-auto text-center flex-shrink-0 border-l border-black dark:border-gray-700 flex flex-col justify-center"
     >
       <button
-        class="h-full mx-1 px-2 rounded-full font-bold hover:bg-gray-400 dark:hover:bg-gray-700 focus:outline-none transition-colors duration-75"
+        class="h-full mx-1 px-2 rounded-full font-bold sm:hover:bg-gray-400 dark:sm:hover:bg-gray-700 focus:outline-none transition-colors duration-75"
         @click="openNewTab(`https://www.virustotal.com/gui/search/${doubleEncodedUrl}`)"
       >
 

diff --git a/src/views/Search.vue b/src/views/Search.vue
@@ -68,12 +68,10 @@
             leave-to-class="-translate-x-64 opacity-0 w-0"
           >
           <div
-            v-if="index == activeTipIndex"
+            :key="activeTipIndex"
             class="h-auto flex flex-col justify-center break-words leading-4"
-            v-for="(tip, index) of tips"
-            :key="index"
           >
-            <span>{{ tip }}</span>
+            <span>{{ activeTip }}</span>
           </div>
           </transition>
         </div>
@@ -147,6 +145,9 @@ export default {
     },
     isLandscape: function() {
       return this.orientation === 'landscape-primary';
+    },
+    activeTip: function() {
+      return this.tips[this.activeTipIndex];
     }
   },
   methods: {