feat: support for scaling modes #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Julusian
approved these changes
Sep 19, 2024
dimitry-ishenko
force-pushed
the
aspect
branch
from
d221c17
to
e41271e
Compare
|
Added ffmpeg_producer as well. The other two in your PR are the channel_producer and layer_producer, neither one of which exist currently. I believe they've been superseded by the route_producer? I will mark it as ready to be pulled. If you see anything else, let me know. @Julusian I can add a helper as you've suggested, but I can't figure out a good place to put it. If you do, let me know and I can refactor. But so far, it's only used in two places, so it may not be worth the trouble. |
dimitry-ishenko
force-pushed
the
aspect
branch
from
22ea81e
to
a3648df
Compare
|
If possible, I would like this to also be back-ported to the 2.4.x branch. I am trying to set up our new playout machine some time next week, and hopefully 2.4.1 will be out by then. |
dimitry-ishenko
force-pushed
the
aspect
branch
from
a3648df
to
9481cd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from nrkno#28 and added
HFILLandVFILLmodes.Only image_producer for now. Will try to do the rest tomorrow.