Creating a sink tap that stores the Tuples in a provided List. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this. Since this is very close to this: would you mind renaming this to JMemorySinkTap to distinguish the two more easily? One of these days I will merge that one in maple. |
|
Since MemorySourceTap is Java I guess my preference would be to leave it MemorySinkTap and make the Scala one SMemoryTap maybe. That being said the decision is really up to you guys. I can live with it either way. |
azymnis
added a commit
that referenced
this pull request
Mar 26, 2013
Creating a sink tap that stores the Tuples in a provided List.
|
Alright, I'm merging this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a sink Tap that stores the Tuples from a flow in a Java List object that is provided to the Tap in the constructor.