Add LocalTap from Etsy, used to side-step lack of SequenceFile implementation for Cascading local mode #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation for Cascading local mode
| */ | ||
| defaults = new JobConf(); | ||
|
|
||
| // HACK: c.t.h.TextLine checks this property for .zip files; the check |
There was a problem hiding this comment.
Hack... is this some sort of Etsy practice?
There was a problem hiding this comment.
Heh, not that I'm aware of. Just calling attention to what feels like a dirty hack. Also, this was written for hack week.
|
Hey, this is awesome. Can I get you to resubmit this pull req against develop? I've made develop the default for future reqs. |
|
Will do. Also, I'll review this a bit more with respect to properties -- cwensel just merged a bit of work I did in response to issues with tap properties in local mode. I most likely won't go so far as to learn Clojure to contribute tests, though =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't clear exactly where to locate this in source, so I opted to just keep it in the package have it in at Etsy. Feel free to move.