Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI setup for PHP 8, CakePHP 5.1. Will fix the deprecations in the TestCases in a separate PR. #1103

Open
wants to merge 3 commits into
base: 14.next-cake5
Choose a base branch
from
Open

Fix CI setup for PHP 8, CakePHP 5.1. Will fix the deprecations in the TestCases in a separate PR. #1103

wants to merge 3 commits into from

Conversation

umer936
Copy link
Contributor

@umer936 umer936 commented Nov 1, 2024

Fix for the PHPUnit testing. Fixes

PHP Deprecated:  Since 5.1.0: Cache config `_cake_core_` is deprecated. Use `_cake_translations_` instead

/home/runner/work/users/users/vendor/cakephp/cakephp/src/I18n/I18n.php, line: 152
You can disable all deprecation warnings by setting `Error.errorLevel` to `E_ALL & ~E_USER_DEPRECATED`. Adding `vendor/cakephp/cakephp/src/I18n/I18n.php` to `Error.ignoredDeprecationPaths` in your `config/app.php` config will mute deprecations from that file only. in /home/runner/work/users/users/vendor/cakephp/cakephp/src/Core/functions.php on line 384
Deprecated: Since 5.1.0: Cache config `_cake_core_` is deprecated. Use `_cake_translations_` instead
/home/runner/work/users/users/vendor/cakephp/cakephp/src/I18n/I18n.php, line: 152
You can disable all deprecation warnings by setting `Error.errorLevel` to `E_ALL & ~E_USER_DEPRECATED`. Adding `vendor/cakephp/cakephp/src/I18n/I18n.php` to `Error.ignoredDeprecationPaths` in your `config/app.php` config will mute deprecations from that file only. in /home/runner/work/users/users/vendor/cakephp/cakephp/src/Core/functions.php on line 384
PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

@umer936 umer936 marked this pull request as draft November 1, 2024 14:43
@umer936
tests/bootstrap.php initializes the plugin twice
67a1f46 
Don't see why this is necessary unless it's to clear the options? If so, it should be handled differently.
@umer936
Fix set-output deprecation in ci.yml
13a3ec7 
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ for deprecation details
@umer936 umer936 changed the title Fix CakePHP 5.1 Cache config name deprecation in tests/bootstrap.php Fix CI setup for PHP 8, CakePHP 5.1. Will fix the deprecations in the TestCases in a separate PR. Nov 1, 2024
@umer936 umer936 marked this pull request as ready for review November 1, 2024 14:59
@ajibarra
Copy link
Member

ajibarra commented Nov 8, 2024

@umer936 Thanks for the contribution! ...I see the tests are failing..could you please take a look?

@ajibarra
Copy link
Member

@umer936 If you are not available to take a look at this, please let us know so we can check if someone else is available. Thank you!

@umer936
Copy link
Contributor Author

umer936 commented Jan 10, 2025 •
edited
Loading

Oh yeah someone else can go for it. I was just doing the deprecation fix part since it was easy. As the title says, this PR wasn't meant to fix any of the tests anyways, just fix the deprecations.

To me it would make sense to merge this, then do the test fixes as at least it would get past the CI setup part.

But yeah feel free to do whatever - I just like having the deprecations/warnings/etc out of the logs; doesn't matter who gets to it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umer936 @ajibarra