Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to pytket 2 #787

Merged
merged 1 commit into from
Feb 28, 2025
Merged

chore: Update to pytket 2 #787

merged 1 commit into from
Feb 28, 2025

Conversation

cqc-alec
Copy link
Collaborator

No description provided.

@cqc-alec cqc-alec changed the title [chore] Update to pytket 2 chore: Update to pytket 2 Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.46%. Comparing base (c89ced7) to head (2a1dc15).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files          65       65           
  Lines        7979     7979           
  Branches     7717     7717           
=======================================
  Hits         6580     6580           
  Misses       1002     1002           
  Partials      397      397           
Flag Coverage Δ
python 82.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cqc-alec cqc-alec requested a review from aborgna-q February 28, 2025 10:32
@cqc-alec cqc-alec marked this pull request as ready for review February 28, 2025 10:32
@cqc-alec cqc-alec requested a review from a team as a code owner February 28, 2025 10:32
@aborgna-q
Copy link
Collaborator

aborgna-q commented Feb 28, 2025

I gather that the serialization format hasn't changed, so we shouldn't need to update tket-json-rs ?

The serialization format has not changed. However, one OpType (OpType.ClassicalExpBox) has been removed -- I guess that would require an update?

@aborgna-q
Copy link
Collaborator

As long as no things are removed we should be fine on the tket-json-rs side. We could maybe deprecate them to avoid people writing new code that generates those ops, but it's better to keep the backwards compatibility.

On the tket2 side we do not generate those ops, so no new changes should be needed.

@cqc-alec cqc-alec added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 64b9c64 Feb 28, 2025
16 of 17 checks passed
@cqc-alec cqc-alec deleted the ae/pytket2 branch February 28, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants