Do not block UI when building ECUs tree #606
Conversation
| } | ||
| project.ecu->clear(); |
There was a problem hiding this comment.
@alexmucde this changes this behavior: #576 (comment) I.e. now every new dlt file import will clean up the ECU tree first and create new one only with its own entries.
This makes this change a bit simpler, unless old behavior was intentional.
|
@alexmucde I would appreciate if you could play with this. I tried not to bring any regressions, but as you can see the change is not small, so I might have introduced some. Also I would appreciate if you could provide data for tests to make them more robust, e.g. raw data to check parsing of other types of payloads except |
vifactor
force-pushed
the
parse-ctrl-msg
branch
3 times, most recently
from
ab12c71 to
f8f3d7d
Compare
vifactor
force-pushed
the
parse-ctrl-msg
branch
2 times, most recently
from
1b050c0 to
efa6ca2
Compare
|
@alexmucde ok, I'll have a look, I now better understand that issue. Keep in mind, it might take some time, while this PR already fixes one very real annoying issue. |
use ctrlmsg parsing function add test Signed-off-by: Viktor Kopp <[email protected]>
fix symbols visibility Fix macos-13 build It still uses qmake, so new sources should be added there too Signed-off-by: Viktor Kopp <[email protected]>
vifactor
force-pushed
the
parse-ctrl-msg
branch
from
efa6ca2 to
a7bd8af
Compare
This PR resolves #576 for the cases when DLT log contains lots of apps and contexts.
Historically, the same function used to populate ECU tree (in the "Config"-tab) both in online and offline modes. This was a problem for offline mode (aka dlt-file loading), because UI update is then called multiple time in a short time frame ate the end of file processing freezing the whole app. The fix is to: