Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-3399: Add internal_application_labels to loggers #1306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stiwarisemanticbits
Copy link
Contributor

@stiwarisemanticbits stiwarisemanticbits commented Mar 19, 2025

JIRA Ticket:
BB2-3399

What Does This PR Do?

Add internal_application_labels to loggers
This will should mapped to quicksight, once mapped we can update quicksight

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

Updated tests

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing logic that satisfying AC#2?

AC#2: In the logs - if data facilitator under the Internal Category, then pull in the header information of the UUID. application-id see https://jira.cms.gov/browse/BB2-3345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants