Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package #143

Open
wants to merge 44 commits into
base: package
Choose a base branch
from
Open

Package #143

wants to merge 44 commits into from

Conversation

bartvanosnabrugge
Copy link
Collaborator

Initial restructuring of CWARHM into python package compatible format

main features:

  • CWARHM code is still available in original form under dependencies/cwarhm_summa
  • The code can be tested by running an example as described in the readme.rst
  • The current example uses a wrapper to run the scripts of the cwarhm_summa code in dependencies/cwarhm_summa (as from fairymwah which is now 'officially discontinued')

Things that are to-do, but not breaking for the current purpose of the package:

  • sphinx documentation settings need to be updated
  • the still relevant bits of the readme.rst from the original have to be merged

@bartvanosnabrugge bartvanosnabrugge self-assigned this Mar 5, 2022
@bartvanosnabrugge bartvanosnabrugge added the package project To do items for the CWARHM package that is currently under development label Mar 5, 2022
bartvanosnabrugge and others added 15 commits March 7, 2022 09:39
@bartvanosnabrugge
Update README.rst
bebe235 
added workflows/summa_bowatbanff/ to the files to be changed so as not to confuse them with the files in cwarhm_summa
@bvanosnabrugge
control file path now set from cwarhm_summa_folder variable
3ae2c0e
@bvanosnabrugge
Merge branch 'package' of https://github.com/bartvanosnabrugge/summaW…
acf53c7 
…orkflow_public into package

updates to readme upstream
@bartvanosnabrugge
Update README.rst
a9b8305 
Issue #8
@bvanosnabrugge
added placeholder files for functions
d392964
@bvanosnabrugge
added placeholder files for functions
e6325bf
@bvanosnabrugge
Merge branch 'package' of https://github.com/bartvanosnabrugge/summaW…
1360d98 
…orkflow_public into package
@bvanosnabrugge
removed qgs.exitQgis() line to prevent segmentation faults when runni…
28719cc 
…ng multiple scripts in order
@guoqiang-tang
era5 merging and default path change
9dad562
@guoqiang-tang
small modification
2bbb922 
rename merge_era5_surface_and_pressure_level_downloads and delete a space
@bartvanosnabrugge
Merge pull request #42 from tgq14-fork/package
2dc2825 
era5 merging and default path change
@bartvanosnabrugge
#11 explicitly add rasterio
715727a
@bvanosnabrugge
added rasterstats to environment
6ba97f3
@bvanosnabrugge
added functions for mesh specific processing, and needed model agnost…
3758130 
…ic processing. added mizuroute mapping as function.
@bvanosnabrugge
added some notes to test file
1778707
bvanosnabrugge and others added 17 commits March 18, 2022 16:25
@bvanosnabrugge
added test sample data
599215a
@bvanosnabrugge
added two classes to mesh.py to write CLASS and RUN OPTIONS ini files
3e34c86 
1) MeshClassIniFile for writing CLASS ini files
2) MeshRunOptionsFile for writing run option ini file

the use is added to test_mesh_bowatbanff.py
@bvanosnabrugge
updated docstrings of MeshClassIniFile
39bb144
@bvanosnabrugge
added MeshHydrologyIniFile class to write MESH_parameters_hydrology.i…
b556938 
…ni file
@bvanosnabrugge
classes for soil_layers file and reservoir.txt file
0cf811b
@bvanosnabrugge
added docstring to easymore wrapper map_forcing_data
444047a
@bvanosnabrugge
comments to reindex_forcing_file
8726e3b
@bvanosnabrugge
in reindex_forcing_file ensured lat lon coordinates are reindexed
880b18d
@bvanosnabrugge
changed default run option flag OUTFILESFLAG to off and removed .nc f…
441858f 
…rom default file
@bvanosnabrugge
file extension is not included when setting FNAME in run_options file
505c967
@bvanosnabrugge
added preprocessing when opening forcing files to read lat lon as coo…
71bfcd0 
…rdinates
@bvanosnabrugge
changed generate_mizuroute_topology to package version
4a79b26
@bvanosnabrugge
merge mesh development from package-dev-mesh branch
f3de148
@bvanosnabrugge
resolved conflict - two different imports on the same line
c273669
@bartvanosnabrugge
Added how to test the mesh model_specific part
9bfb869
@bvanosnabrugge
era5 download script in python
68575b7
@bvanosnabrugge
update to era5 download and split download and further steps in test …
89921ef 
…file

- era5 is now downloaded with two functions: one to create the requests and one to download the requests when ready
- the download section of the workflow is now in a seperate script
- paths are improved in test file (e.g. dependencies/cwarhm-summa is now set as relative path)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wknoben wknoben Awaiting requested review from wknoben

Assignees

@bartvanosnabrugge bartvanosnabrugge

Labels
package project To do items for the CWARHM package that is currently under development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartvanosnabrugge @bvanosnabrugge @guoqiang-tang