Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foqus cloud #1242

Merged
merged 34 commits into from
Oct 14, 2024
Merged

Foqus cloud #1242

merged 34 commits into from
Oct 14, 2024

Conversation

boverhof
Copy link
Member

@boverhof boverhof commented Sep 24, 2024

Fixes/Addresses:

Moves specification of file path locations to foqus.core, including changing default location for SimSinter and TurbineLite. This is incomplete, but the intent is to provide one place where these paths can be managed, specified and requested.

improvements to the foqus.service module, which is used by the foqus cloud.

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@boverhof boverhof self-assigned this Sep 24, 2024
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Sep 24, 2024
@@ -0,0 +1,211 @@
###############################################################################
# FOQUS Copyright (c) 2012 - 2021, by the software owners: Oak Ridge Institute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this is the new copyright header, with at least this year in the range.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 64.59627% with 57 lines in your changes missing coverage. Please review.

Project coverage is 38.87%. Comparing base (4a212b1) to head (06110ec).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
foqus_lib/core.py 63.70% 43 Missing and 2 partials ⚠️
foqus_lib/service/flowsheet.py 56.52% 10 Missing ⚠️
foqus_lib/framework/sim/turbineConfiguration.py 66.66% 1 Missing ⚠️
foqus_lib/framework/sim/turbineLiteDB.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
+ Coverage   38.77%   38.87%   +0.09%     
==========================================
  Files         164      165       +1     
  Lines       37139    37281     +142     
  Branches     5722     5729       +7     
==========================================
+ Hits        14402    14492      +90     
- Misses      21612    21662      +50     
- Partials     1125     1127       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boverhof boverhof merged commit 7ef873d into CCSI-Toolset:master Oct 14, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants