Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate test warnings due to invalid uuids #183

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

larsks
Copy link
Member

@larsks larsks commented Jan 24, 2025

Tests results would include warnings along the lines of:

FutureWarning: b"'test-node'" is an invalid UUID. Using UUIDFields with
invalid UUIDs is no longer supported, and will be removed in a future
release. Please update your code to input valid UUIDs or accept ValueErrors
for invalid UUIDs.

This commit ensures that tests are using valid UUIDs.

Tests results would include warnings along the lines of:

> FutureWarning: b"'test-node'" is an invalid UUID. Using UUIDFields with
> invalid UUIDs is no longer supported, and will be removed in a future
> release. Please update your code to input valid UUIDs or accept ValueErrors
> for invalid UUIDs.

This commit ensures that tests are using valid UUIDs.
@larsks larsks requested a review from tzumainn January 24, 2025 16:03
@joachimweyl
Copy link

@tzumainn noticed this while reviewing PRs.

Copy link
Contributor

@tzumainn tzumainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks!

@tzumainn tzumainn merged commit 322a0c2 into CCI-MOC:master Feb 10, 2025
14 checks passed
@larsks larsks deleted the fix/uuid-warnings branch February 10, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants