Skip to content

Add system ringtones feature to alarm clock #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add system ringtones feature to alarm clock #795

wants to merge 1 commit into from

Conversation

rakshitjain23
Copy link

Feature: System Ringtone Option in Alarm Settings

Added Features

  • Added a new "System Ringtones" option in the alarm settings
  • Integrated with device system ringtones for wider sound options
  • Implemented proper UI styling with clear text contrast and icons
  • Fixed visibility issues with popup menu to ensure text is readable

Implementation Details

  • Added system ringtone selection dialog
  • Connected to device ringtone library
  • Ensured proper theming across light and dark modes
  • Fixed color contrast for better visibility

Demo

before.mp4
after.mp4

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@rakshitjain23
Copy link
Author

@MarkisDev Please review now

@rakshitjain23 rakshitjain23 mentioned this pull request Mar 29, 2025
Open
@rakshitjain23
Copy link
Author

@MarkisDev Please tell me if any changes needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rakshitjain23