Add close tray button to popover test. #5327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dbatiste
commented
Jan 17, 2025
| @@ -67,8 +66,8 @@ class Popover extends PopoverMixin(LitElement) { | |||
| * @type {boolean} | |||
| */ | |||
| trapFocus: { type: Boolean, reflect: true, attribute: 'trap-focus' }, | |||
| _hasFooter: { state: true }, | |||
| _hasHeader: { state: true } | |||
| _hasFooterSlotContent: { state: true }, | |||
There was a problem hiding this comment.
I just renamed these to make it clearer, since they are specifically in regard to whether the consumer has placed content in the header or footer slots.
Oh yeah, thanks for pointing that out. I'll fix that in the next round of changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GAUD-7122
This PR adds the tray's Close button to the test popover component.