Updating package-lock.json #5316
Conversation
![d2l-github-action-tokens[bot]](https://avatars.githubusercontent.com/u/5429170?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
d2l-github-action-tokens
bot
force-pushed
the
ghworkflow/package_lock_auto_update
branch
from
bf7e731 to
452f57f
Compare
components/filter/filter.js
Outdated
| word-break: break-word; | ||
| overflow-wrap: anywhere; | ||
| word-break: normal; |
There was a problem hiding this comment.
break-word has been deprecated but is still supported currently. See here at the bottom of the section, which states "When specified, this has the same effect as word-break: normal and overflow-wrap: anywhere, regardless of the actual value of the overflow-wrap property." so I've replaced the word-break with those.
There was a problem hiding this comment.
Yeah I've have really good results using overflow-wrap: anywhere;.
Do we still need word-break: normal; if we're removing word-break: break-word;?
There was a problem hiding this comment.
I think probably not as normal is the default. I kept it in to protect against future additions of word-break not noticing the overflow-wrap but that's likely an edge case issue and it should be safe to remove.
| display: hidden; | ||
| display: none; |
There was a problem hiding this comment.
hidden is not a supported value for display. I'll confirm that no where was using d2l-focus-trap hidden as this would suddenly cause previously visible cases to now not be.
There was a problem hiding this comment.
I have not found any cases where hidden is used on d2l-focus-trap so this change should be safe.
| .d2l-form-panel-demo-container { | ||
| margin-bottom: 10px; | ||
| } | ||
|
|
||
| .d2l-form-panel-demo-header { | ||
| align-items: top; |
There was a problem hiding this comment.
top is not a supported value for align-items. This css was also just no longer used so I cleaned it up.
| @@ -26,7 +26,6 @@ class FormErrorSummary extends LocalizeCoreElement(RtlMixin(LitElement)) { | |||
| } | |||
|
|
|||
| .d2l-form-error-summary-header { | |||
| align-items: top; | |||
There was a problem hiding this comment.
top is not a supported value for align-items and this looked fine without so I didn't replace it with a different value.
components/inputs/input-textarea.js
Outdated
| overflow-wrap: anywhere; /* prevent width from growing */ | ||
| padding-bottom: 0.5rem; | ||
| padding-top: 0.5rem; | ||
| visibility: hidden; | ||
| word-break: break-word; /* prevent width from growing */ | ||
| word-break: normal; |
d2l-github-action-tokens
bot
force-pushed
the
ghworkflow/package_lock_auto_update
branch
from
2df3d7f to
5af2b75
Compare
|
If anyone has concerns with these changes, let me know. Otherwise I'll get this merged by EOD to prevent override when the action runs again. |
d2l-github-action-tokens
bot
deleted the
ghworkflow/package_lock_auto_update
branch
Automatic update of the
package-lock.jsonfile.Dependency Changes