-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated Freshman First Dapp tutorial to Goerli testnet #9
Open
0xumarkhatab
wants to merge
29
commits into
BlockDevsUnited:master
Choose a base branch
from
0xumarkhatab:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Slava Timbaliuc <[email protected]>
* Update mood.sol contract to same solidity version used in the README.md I think it is confusing if the README.me is using the 'string memory' but the full example contract dosn't. * Link mood.sql full example to https://github.com/LearnWeb3DAO The mood.sol full example was linked to https://github.com/BlockDevsUnited, so it could not be updated. Co-authored-by: Philipp Dahse <[email protected]>
I've added a line about clicking Ethereum Mainnet button to switch to Ropsten Testnet. Also I've added another faucet for Ropsten Network because of some technical issues happening with the current one. Co-authored-by: Sneh Koul <[email protected]>
* Spelling/Phrasing Fix, Missing Links * Update README.md Resolved initial PR issues.
* removing faucet that has reached EOL * moving 6th list item to next line like 1-5
* Update JS to use ES6, update Ethers code to use up-to-date code, and add basic styles * Update to reflect finished project based on tutorial * Capitalize some words and change all instances of Ethersjs to Ethers.js, and Node JS to Node.js * Capitalize HTML: * Capitalizations * Change IIFE to .then * Swap steps Co-authored-by: Jordan Baron <[email protected]>
The [updated ABI spec](https://docs.soliditylang.org/en/latest/abi-spec.html) no longer includes the `constant` and `payable` fields. This has caused some confusion for students (example: https://discord.com/channels/872804414107312158/920317342028824637/975053564953112727)
there are two script open tags and three close tags. removed the accidental extra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have taken this step to provide support of our tutorial for future students
as Rinkeby and Ropsten are both going to be depreciated in Future.
Everything is tested well.
Added faucet links to Goerli
Replaced Ropsten information with correct information of Goerli
Verified Smart contract on Goerli and added verification links at the end