Add logging infrastructure #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,29 +9,39 @@ class BaseConfig(object): | |||
| DEBUG = False | |||
| TESTING = False | |||
| MONGODB_SETTINGS = {'db': 'bikeshare'} | |||
| LOGGING_FORMAT = '%(asctime)s - %(name)s - %(levelname)s - %(message)s' | |||
| LOGGING_LOCATION = 'bikeshare.log' | |||
| LOGGING_LEVEL = logging.INFO | |||
|
|
|||
| class TestingConfig(BaseConfig): | |||
| """Configuration for running unit tests""" | |||
| DEBUG = False | |||
There was a problem hiding this comment.
There's no need to have this line since DEBUG is False in super()
| """This endpoint is for requesting a bike""" | ||
| app.logger.debug('User %s requesting bike %d' % (user_email, bike_id)) |
There was a problem hiding this comment.
%-formatting is "old style formatting." The Python community is still trying to oust this in favor of the .format() method, eg 'User {} requesting bike {}'.format(user_email, bike_id). The {} is where the parameters will fall into and you can do lots of things with it, in fact the CFG that describes this new format string can be found here.
|
I approve, waiting if @alanplotko has anything to say |
|
Looks good on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25