Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Fix X image visibility in the marketplace search sort menu and darken the slider button hover in Dark UI #522

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

PAPISOP
Copy link
Member

@PAPISOP PAPISOP commented Feb 12, 2025

  1. Fixed the X image in sort menu not being visible in marketplace search
  2. Fixed the button being hovered in the pack subpacks selector being not dark
  3. Update Old Metal Blocks to use new iron sound for iron block

Resolves #507

By checking the following boxes with an X, you ensure that:

  • The pack was tested ingame in at least one device.

  • The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.

  • The pack code follows the style guide.

  • The commits follow the contribution guidelines.

  • The PR follows the contribution guidelines.

  • (Optional) Tested in Windows

  • (Optional) Tested in Android

  • (Optional) Tested in iOS

  • (Optional) Tested in any console

  • (Optional) Tested in BDS

…lace search and fix the button being hovered in the pack subpacks selector being not dark

1. Fixed the X image in sort menu not being visible in marketplace search
2. Fixed the button being hovered in the pack subpacks selector being not dark
@PAPISOP PAPISOP requested a review from drav0011 February 12, 2025 09:30
@PAPISOP PAPISOP changed the title fix(files): Fix the X image in sort menu not being visible in marketplace search and fix the button being hovered in the pack subpacks selector being not dark fix(files): Fix X image visibility in sort menu in marketplace search and dark hover issue in resource pack subpacks selector Feb 12, 2025
@PAPISOP PAPISOP changed the title fix(files): Fix X image visibility in sort menu in marketplace search and dark hover issue in resource pack subpacks selector fix(files): Fix X image visibility in sort menu in marketplace search and slider button hover issue being not dark in resource pack subpacks selector Feb 12, 2025
@PAPISOP PAPISOP changed the title fix(files): Fix X image visibility in sort menu in marketplace search and slider button hover issue being not dark in resource pack subpacks selector fix(files): Fix X image visibility in sort menu in marketplace search and slider button hover being not dark issue in resource pack subpacks selector Feb 12, 2025
@PAPISOP PAPISOP changed the title fix(files): Fix X image visibility in sort menu in marketplace search and slider button hover being not dark issue in resource pack subpacks selector fix(files): Fix X image visibility in sort menu in marketplace search and slider button hover being not dark issue Feb 12, 2025
@PAPISOP PAPISOP changed the title fix(files): Fix X image visibility in sort menu in marketplace search and slider button hover being not dark issue fix(files): Fix X image visibility in the marketplace search sort menu and darken the slider button hover Feb 12, 2025
@drav0011 drav0011 merged commit 508926f into BedrockTweaks:devel Feb 13, 2025
@PAPISOP PAPISOP changed the title fix(files): Fix X image visibility in the marketplace search sort menu and darken the slider button hover fix(files): Fix X image visibility in the marketplace search sort menu and darken the slider button hover in Dark UI Feb 19, 2025
@PAPISOP PAPISOP added the resource_packs Indicates the issue is related to Resource Packs label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resource_packs Indicates the issue is related to Resource Packs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GUI] Dark UI
2 participants