Fix test cases in test_get_ordered_cycle_all_node_cycles (issue #71)
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates `test_get_ordered_cycle_all_node_cycles` to switch test cycles based on python version due to changes in upstream NetworkX code
|
It looks like my local Python 3.8 environment was not sufficiently updated to trip the |
|
Updating from NetworkX v3.0 to 3.1 broke the test locally. I'm guessing it has to do with some algorithmic change in this PR. I'll try updating the test to check the |
* Change `test_get_ordered_cycle_all_node_cycles` test cases to delineate by networkx version instead of Python version
|
Alright, simple change and tests are now passing. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes CI, BUG: Tests Failing on Python 3.9 #71
Updates
test_get_ordered_cycle_all_node_cyclesto switch test cycles based on python version dueto changes in upstream NetworkX code