MAINT: Clean up code in calculations.py module
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restructures all calculation functions so the symbolic output is first in the code path * Changes all `output_strings`/`key` mismatch errors to use the same error message * Various variable name changes to make code more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructures all calculation functions so
the symbolic output is first in the code path
Changes all
output_strings/keymismatcherrors to use the same error message
Changes various variable names to make
code more readable
Simplifies kinetic rate (name) capture
in
calc_state_probsandcalc_sigmaforthe
ouput_strings=Truecode pathSimplifies returns for all functions so
it is clear what the difference is between
the
output_stringscode paths