Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum ItemHoldEffect #5

Closed
wants to merge 2 commits into from
Closed

Use enum ItemHoldEffect #5

wants to merge 2 commits into from

Conversation

mrgriffin
Copy link

Contains 9b5e4f0 which needs to go to pret first—the : u8 is necessary for save compatibility in include/global.berry.h, and also makes the CMD_ARGS usages cleaner.

@mrgriffin
Copy link
Author

I've improved on 9b5e4f0 in pret#2043, so there's that... 😅

I can rebase to discard 9b5e4f0 when my other PR is accepted by pret and makes its way into Expansion.

@mrgriffin
Copy link
Author

Original PR got accepted, so I'll PR this separately :)

@mrgriffin mrgriffin closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrgriffin