Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoist DM plan stubs from XPCS and make generic #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@prjemian prjemian self-assigned this Nov 11, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11786279182

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 37 (35.14%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 79.702%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/instrument/plans/dm_plans.py 10 34 29.41%
Totals Coverage Status
Change from base Build 11713321871: -3.3%
Covered Lines: 428
Relevant Lines: 537

💛 - Coveralls

Copy link
Collaborator

@MDecarabas MDecarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think if we add a README that showcases how to use the plan with a set of example inputs we're golden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants