Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge/release/february 2025 2025 02 20 #2238

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tadelesh
Copy link
Member

No description provided.

iscai-msft and others added 9 commits February 12, 2025 22:12
Deprecate `clientNamespace` property in `SdkClientType`,
`SdkNullableType`, `SdkEnumType`, `SdkUnionType` and `SdkModelType`. Use
`namespace` instead.

fix: #2123
1. Add `pagingMetadata.continuationTokenParameterSegments` and
`pagingMetadata.continuationTokenResponseSegments` to
`SdkPagingServiceMetadata` to indicate the mapping of continuation token
parameter and response.
2. Deprecate `__raw_paged_metadata`, `nextLinkPath` and
`nextLinkOperation` in `SdkPagingServiceMethodOptions`. Use
`pagingMetadata.__raw`, `pagingMetadata.nextLinkSegments` and
`pagingMetadata.nextLinkOperation` instead.
3. Make `SdkServiceResponseHeader` to be part of `SdkModelPropertyType`.
Then it could contain the client related info.
4. Deprecate `resultPath` in `SdkMethodResponse`. Use `resultSegments`
instead.
5. Add `SdkPagingServiceMetadata` type to store all paging related info.


resolve: #2168
resolve: #2139
resolve: #1920
resolve: #2199

design is
[here](#2139 (comment))
…eader (#2229)

for any spread cases, we need to use root source property to do the
comparison.
@tadelesh tadelesh enabled auto-merge February 20, 2025 10:27
@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Feb 20, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 20, 2025

❌ There is undocummented changes. Run chronus add to add a changeset or click here.

The following packages have changes but are not documented.

  • @azure-tools/typespec-client-generator-core
Show changes

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 20, 2025

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@tadelesh tadelesh added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants