Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Refactor option, removing some description from PR template #354

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

manasachi
Copy link
Contributor

Description

Updating PR template to include Refactor option, updating descriptions in some sections.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tatsinnit Tatsinnit added the enhancement New feature or request label Jul 31, 2024
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the kind ping. Absolutely, looks great to me. ❤️☕️🙏

:) Question please:

Why are we using direct repo to create branches and not fork, please?

Screenshot 2024-08-06 at 8 51 24 AM

@manasachi manasachi changed the title Adding Refactor option, removing some test from PR template Adding Refactor option, removing some description from PR template Aug 6, 2024
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@davidgamero davidgamero enabled auto-merge (squash) September 6, 2024 16:29
@davidgamero
Copy link
Collaborator

agreed we can use forks for making PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants